Smart submit mode #110
Open
Smart submit mode #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olszowski can you rebase to solve the conflicts ? |
grzanka
reviewed
Jun 30, 2018
mcpartools/mcengine/fluka.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import logging | |||
| import os | |||
|
|
|||
There was a problem hiding this comment.
Please avoid whitespace changes
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 63.82% 65.67% +1.85%
==========================================
Files 12 13 +1
Lines 868 976 +108
==========================================
+ Hits 554 641 +87
- Misses 314 335 +21
Continue to review full report at Codecov.
|
grzanka
reviewed
Jun 30, 2018
| @@ -11,5 +11,6 @@ def __init__(self, options_content): | |||
| JobScheduler.__init__(self, options_content) | |||
|
|
|||
| submit_script_template = os.path.join('data', 'submit_slurm.sh') | |||
| smart_submit_script_template = os.path.join('data', 'smart_submit_slurm.sh.j2') | |||
There was a problem hiding this comment.
It's a jinja2 template, I wanted this to be explicit.
grzanka
reviewed
Jun 30, 2018
mcpartools/scheduler/smart/slurm.py
Outdated
| node_ids = [] | ||
| for node in nodes_sorted: | ||
| count = int(round(node.cpu_idle * ratio)) | ||
| from itertools import repeat |
There was a problem hiding this comment.
Why doing import inside the loop ?
move import outside the loop
grzanka
reviewed
Jul 20, 2018
mcpartools/scheduler/smart/slurm.py
Outdated
| def get_cluster_state_from_os(): | ||
| from subprocess import check_output, STDOUT | ||
| from shlex import split | ||
| command = "sinfo --states='idle,mixed' --partition=plgrid --format='%n %P %O %T %C'" |
There was a problem hiding this comment.
why plgrid partition is hardcoded ?
|
Two things:
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, although main concept is present. Has some bugs, need to spend a little bit more time on it.